Move handling of parachute mission commands into AP_Mission_Commands #10385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, makes a lot of sense. For support purposes though it's important that we know when the parachute has been deployed. I suspect this means that we need to move events into the dataflash log library? |
|
On Thu, 31 Jan 2019, Randy Mackay wrote:
For support purposes though it's important that we know when the parachute has been deployed. I suspect this means that we need to move events into the
dataflash log library?
tridge has already OK'd that IIRC.
|
peterbarker
force-pushed
the
parachute-mavlink
branch
from
3f87511
to
8cb5bca
Compare
|
@rmackay9 I've created a PR to move event logging up. |
peterbarker
force-pushed
the
parachute-mavlink
branch
4 times, most recently
from
bb0a537
to
8ab4d7f
Compare
|
@rmackay9 We now do events in the dataflash library, and parachute here takes advantage of that. |
|
Marked devcalltopic for attention |
|
redo - link in parachute instead |
peterbarker
force-pushed
the
parachute-mavlink
branch
from
8ab4d7f
to
eb8af80
Compare
|
I've changed the build to include AP_Parachute rather than using stub functions - as discussed on the devcall. |
peterbarker
force-pushed
the
parachute-mavlink
branch
from
eb8af80
to
81d482c
Compare
Tools: autotest: add test for triggering parachute via mavlink Tools: autotest: add Copter mission test for parachute release Tools: autotest: add Plane test for parachute deployment in auto
peterbarker
force-pushed
the
parachute-mavlink
branch
from
81d482c
to
3af2cb6
Compare
|
After discussion on the call I moved the text-message-sending into the library itself, and didn't log the parachute event if it's not enabled. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Copter logs will not get Event entries.