Add Gripper support to Rover #10455
Merged
Add Gripper support to Rover #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/rover-gripper-mission-test
branch
from
fe3ab04
to
f904405
Compare
|
I actually already thought we had gripper support and I had even added it to the release notes. https://github.com/ArduPilot/ardupilot/blob/master/APMrover2/release-notes.txt#L52 |
peterbarker
force-pushed
the
pr/rover-gripper-mission-test
branch
from
f904405
to
0628c3c
Compare
|
It refuses to pass the rover test for some reason.. |
peterbarker
force-pushed
the
pr/rover-gripper-mission-test
branch
from
0628c3c
to
938293a
Compare
|
@rmackay9 I think I found that problem. New test left the vehicle armed, and the protection I put into autotest.py which is supposed to protect against that happening appears to be broken (at least on Rover). Since you can't arm when armed, a subsequent, unrelated test, was failing. |
|
Merged, thanks! |
|
This was on the list to backport to Rover-3.5 but it's not merging cleaning so I'll probably leave it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.