Add PID_TUNING support to Tracker / move sending of that up #10664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... I also added a simple test suite for the message. |
IamPete1
reviewed
Feb 28, 2019
peterbarker
force-pushed
the
pr/tracker-pid-message
branch
4 times, most recently
from
452fc24
to
0d418fa
Compare
peterbarker
force-pushed
the
pr/tracker-pid-message
branch
from
0d418fa
to
1764eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PID_TUNING support has been extracted from one of @IamPete1 's PRs.
Since all our vehicles now support that message I've moved the relevant functions into the GCS_MAVLink class. In the future I hope to factor some of the logic for these functions up into the GCS_MAVLink base class; Copter's implementation of
send_pid_tuninghints as to what we might be able to do.I have not made the function
constas I'd like to NOT send all PIDs out in one big blurt of data, but cycle through each in turn. That will require keeping state.