Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mission: Send jump tracking info to GCS #11120

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

Jaaaky
Copy link
Contributor

@Jaaaky Jaaaky commented Apr 15, 2019

Send jump wp index and jump count to GCS to allow user to track it.

@rmackay9
Copy link
Contributor

I see the usefulness of this and opinions on the dev team vary but I'm not a big fan of using send_text when everything is going as it should...

@auturgy
Copy link
Contributor

auturgy commented Apr 15, 2019

Potential use case for #11108

@OXINARF
Copy link
Member

OXINARF commented Apr 16, 2019

I agree with @rmackay9.

By the way, and in any case, @Jaaaky thank you for your first contribution! For this to go in, it would need to follow our commit message rule though (if you haven't read it, http://ardupilot.org/dev/docs/submitting-patches-back-to-master.html) - it can be done for you since you are still starting, but please take it in consideration for future PRs.

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Apr 17, 2019

@rmackay9 I think all sorts of mission information is currently sent as send_text() . Like; wp number, type, loiter time completed and many more others. So I think this change is consistent with the current code, until all of this is removed if another better/less bandwidth way is established.
And there is actually no real way to know how many jumps do_jump has accomplished, other than counting by hand :)

@OXINARF Thanks. I'm aware of it, but which rule I did not comply with to take care next time?
Maybe adding "AP_Mission: " at the beginning?

@Jaaaky Jaaaky changed the title Send jump tracking info to GCS AP_Mission: Send jump tracking info to GCS Apr 17, 2019
@rmackay9
Copy link
Contributor

@Jaaaky, yes, I see your point. I think we will discuss it on next Tuesday's dev call ('cuz Francisco added the DevTopicItem). Opinions in the dev team are split on the use of send-text so you may get your way :-)

@OXINARF
Copy link
Member

OXINARF commented Apr 17, 2019

Thanks. I'm aware of it, but which rule I did not comply with to take care next time?
Maybe adding "AP_Mission: " at the beginning?

@Jaaaky yes, that's right, all commit messages need to start to with library/vehicle/folder that it belongs to.

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 22, 2019

We discussed this on the dev call and the consensus was that this would be useful but it would be good to make the message display something like, "Jump 4 of 5". Also we'd like to get the condition covered where this path isn't run at all.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea, I'd like two small changes though
First is to ensure we also log when we won't be jumping (ie. last jump)
and display should be something like
Jump to 17 (4 of 5)

@Jaaaky
Copy link
Contributor Author

Jaaaky commented Apr 24, 2019

I've formatted the jump message as request. Also made it consistent with other Mission items send_text() format.

For the last jump, it's already there. As we send the message when it starts the jumping track not when it ends. Just test please and tell me if more changes are needed.

@Jaaaky Jaaaky force-pushed the patch-1 branch 2 times, most recently from c5162b1 to 520ff3d Compare April 24, 2019 18:56
@rmackay9
Copy link
Contributor

@Jaaaky, thanks. One last change is that the commit message itself should be prefixed with "AP_Mission:". So it should become, "AP_Mission: send jump tracking info to GCS" or something similar.

Send jump wp index and jump count to GCS to allow user to track it.
Foramtted as other mission item messages
@Jaaaky
Copy link
Contributor Author

Jaaaky commented Apr 25, 2019

@rmackay9 Done. Thank you too for your patience.

@rmackay9 rmackay9 merged commit dd4f7e5 into ArduPilot:master Apr 25, 2019
@rmackay9
Copy link
Contributor

Merged, thanks!

@Jaaaky Jaaaky deleted the patch-1 branch April 25, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants