Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Declination: update magnetic tables #11804

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Jul 14, 2019

and use new python module to grab data
Note that new method uses an online server and is a bit slow. Python3 only.

@tridge tridge requested a review from WickedShell July 14, 2019 08:09
Copy link
Contributor

@WickedShell WickedShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rational for the change? This moves to using a third party Internet service for doing the calculations, rather then just reading a local database and generation, which leaves us stranded if the API/endpoints change.

generate/README.md is also stale now, and would need an update.

added ability to display max error
max interpolate error between -60 and 60 latitude is 13.86 mGauss
@tridge
Copy link
Contributor Author

tridge commented Dec 20, 2019

I've switched back to the IGRF12 module

@tridge tridge merged commit 7b4b88d into ArduPilot:master Dec 24, 2019
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tridge tridge added this to 4.0.1-rc1 in Copter 4.0 backports Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Copter 4.0 backports
4.0.1-rc1/-rc2
Plane 4.0 Backports
  
Awaiting triage
Rover 4.0 backports
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

5 participants