add NMEA Input library #12289
Closed
add NMEA Input library #12289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
NMEA-combine
branch
2 times, most recently
from
5063eed
to
5693cee
Compare
|
From a practical point of view, this would be much easier to get into master if the GPS parts were removed. Touching the NMEA GPS is such a critical part of the code that it will require a much higher level of review and testing vs the changes for the windvane and range finder which are rarely used. If it were me I'd take it in steps, get the range finder and windvane changes in, then put the NMEA GPS changes in a follow-up PR. |
IamPete1
force-pushed
the
NMEA-combine
branch
from
5693cee
to
a01cfa3
Compare
|
rebased and dropped the GPS bit |
IamPete1
force-pushed
the
NMEA-combine
branch
from
a01cfa3
to
72872e3
Compare
|
rebased |
IamPete1
force-pushed
the
NMEA-combine
branch
from
72872e3
to
cb76d6f
Compare
|
fixed bad rebase |
|
I'm going to close this, there is no saving in code without the GPS drivers and its a big job to re-test the rangefinders (and I don't have any) let alone the GPS stuff if that were to be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new NMEA input library and uses it for WindVane, GPS and Rangefinder. I have only tested a with windvane. It is hoped this will make it easier to add new NMEA inputs in the future (AIS). Hopefully it also removes a bit of duplicated code.
This is getting to the limit of my C++ so apology's if i have done it in a odd way.