Tools: add --upload-port option to waf #12404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
approved these changes
Sep 25, 2019
andyp1per
force-pushed
the
pr-waf-upload-port
branch
from
22a623c
to
06fe734
Compare
tridge
reviewed
Sep 30, 2019
|
I've done changes to improve this on WSL and it works for me fine. Are you still having problems with the latest master implementation? |
|
It's been working well for me on WSL too |
|
Yes, it basically hangs for me, whereas if I specify the tty it works instantly. I think it depends what devices you have connected to the other serial ports. There are also a lot of ports (192 in my case) so to get to ttyS14 say you have to look at 46 other ports first. Given that the uploader has this option (and I wouldn't be able to use it if it didn't) what's the issue in adding the option? |
|
@andyp1per this should be merged, but can you add the default=None? |
|
Yes certainly |
andyp1per
force-pushed
the
pr-waf-upload-port
branch
from
06fe734
to
e2c90b0
Compare
|
@tridge ok done |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows WSL at least, autodetect on upload does not work well and specifying a port is necessary. This allows this be done from the waf command-line
@peterbarker FYI