Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-fill SITL stack for main loop with NaN #12440

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Sep 28, 2019

This allows us to catch use of uninitialised stack variables in SITL without having to run valgrind, which makes it more likely we will find bugs in CI

@tridge
Copy link
Contributor Author

tridge commented Sep 30, 2019

  • suggestion to pre-fill in scheduler task run
  • check cpu cost of this
  • possibly use memset 0xff instead

we want use of these values to trigger a FPE
this allows us to catch use of uninitialised stack variables in SITL
without having valgrind running
broken by recent common variable change
@tridge tridge merged commit ddde512 into ArduPilot:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants