Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_OpticalFlow: add UPFlow serial driver #12959

Open
wants to merge 2 commits into
base: master
from

Conversation

@auturgy
Copy link
Contributor

auturgy commented Dec 3, 2019

Closes #11328
Basically a duplicate of the CXOF driver, modified for the different packet structure/order
It builds, but that is the limit of testing. Needs testing on hardware.

@auturgy

This comment has been minimized.

Copy link
Contributor Author

auturgy commented Dec 3, 2019

overflows MatekF405-wing by 20 bytes (1Mb flash). Suggestions?

@bys1123

This comment has been minimized.

Copy link
Contributor

bys1123 commented Dec 3, 2019

image
image
Data Format Reference for other developers.

@rmackay9

This comment has been minimized.

Copy link
Contributor

rmackay9 commented Dec 3, 2019

@auturgy, the easiest thing to try and do is move some feature or flight mode into HAL_MINIMIZE_FEATURES.

  • BUTTON_ENABLED is the only one that stands out to me (see Copter's config.h)

I think the next step is to look for rarely used drivers. Some ideas:

  • AP_Proximity's SF40C_v09 driver.
  • AP_RobotisServos are very rarely used

Maybe there are some compass or imu drivers that we could get rid of.

@auturgy

This comment has been minimized.

Copy link
Contributor Author

auturgy commented Dec 3, 2019

@andyp1per

This comment has been minimized.

Copy link
Contributor

andyp1per commented Dec 3, 2019

@rmackay9 MatekF405-wing doesn't have HAL_MINIMIZE_FEATURES switched on - I think it should as I keep tripping over flash limits on this board.

@auturgy

This comment has been minimized.

Copy link
Contributor Author

auturgy commented Dec 3, 2019

Yeah: massive scope creep, so I’ll address it separately, but I think I’ll do an audit of minimise to see what we can shove behind it en masse, to push this problem as far down field as possible

@andyp1per

This comment has been minimized.

Copy link
Contributor

andyp1per commented Dec 3, 2019

I actually think we have the cut wrong. We have used it to address the old Pixhawk limitation in a certain class of copter but we also run into it on these single boards which are put on a very different class of copter. I suspect there ought to be two definitions based on the different kind of targets.

@auturgy

This comment has been minimized.

Copy link
Contributor Author

auturgy commented Dec 3, 2019

I sort of agree - but the old errata on Pixhawk is such a legacy issue I think I’d rather ignore it moving forward :)
One issue is that those old boards (I still have one for the bench) actually have more constrainted flash, as they need to carry the iomcu firmware within the main flash space.
As above, I’ll look at the flash problem separately and see what I can come up with.

@andyp1per

This comment has been minimized.

Copy link
Contributor

andyp1per commented Dec 3, 2019

Do we know why the MatekF405-wing is so much worse than some of the other simple boards?

@auturgy

This comment has been minimized.

Copy link
Contributor Author

auturgy commented Dec 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.