AP_Arming: Display mag field value #13166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally ok but let's make the format so that it doesn't show any decimal places ("%4.0f"?). I think we also need to cast "mag_field" with (double). So it should be, ".. (double)mag_field);" in order to avoid a compiler warning. It would be nice to also show the acceptable range (I.e. "mag field 5688 > 875") but this isn't a hard requirement for this PR to go in. It's an improvement in any case. |
khancyr
force-pushed
the
AP_mag_field_value
branch
from
1d39e6e
to
ff449a1
Compare
|
Merged, thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I turned on the flight controller Durandal indoors.
I often see the message “PreArm: Check mag field” in Mission Planner, QgroundControl, and APM Planner2.
I put the same revision of AC4.0.1-dev in PIXRACER, PIXHAWK. I learned that this message did not appear.
I have found that it appears above 875 or below 185.
I think it is better to display the judgment value.
In this environment it is over 5000.
I checked this value while moving the aircraft.
I saw it change.
After message:
PreArm: Check mag field 5688.519