Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add known Calibration parameter tag #13450

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Add known Calibration parameter tag #13450

merged 3 commits into from
Feb 4, 2020

Conversation

peterbarker
Copy link
Contributor 

<parameters name="COMPASS_">
<param humanName="Compass offsets in milligauss on the X axis" name="COMPASS_OFS_X" documentation="Offset to be added to the compass x-axis values to compensate for metal in the frame" user="Advanced" calibration="1">
<field name="Calibration">1</field>
<field name="Range">-400 400</field>
<field name="Increment">1</field>
<field name="Units">mGauss</field>
<field name="UnitText">milligauss</field>

@peterbarker peterbarker changed the title Add known Calibration tag Add known Calibration parameter tag Feb 2, 2020
@amilcarlucas
Copy link
Contributor

I can see why this is interesting. What uses are you planning for it ?

@peterbarker
Copy link
Contributor Author

@amilcarlucas primarily it allows the GCS to filter out parameters the user is very unlikely to want to change. It could have a checkbox for showing them or not, or avoid sending them to the vehicle on an upload without a force option.

tridge
tridge requested changes Feb 4, 2020
View reviewed changes
libraries/AP_Compass/AP_Compass.cpp Outdated
@@ -170,6 +178,8 @@ const AP_Param::GroupInfo Compass::var_info[] = {
// @Units: mGauss
// @Increment: 1
// @User: Advanced
// @Calibration: 1
// @Calibration: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubly calibrated?

@amilcarlucas
Copy link
Contributor

Nice!!

@peterbarker
Copy link
Contributor Author

peterbarker commented Feb 4, 2020 via email

@peterbarker peterbarker merged commit ab7ee46 into ArduPilot:master Feb 4, 2020
@peterbarker peterbarker deleted the pr/calibration-tag branch February 6, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterbarker @amilcarlucas @tridge @CraigElder