-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move initialisation of SerialManager and GCS up to AP_Vehicle #13554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it !
This need a small override fix on rover
AP_Stats could be moved too, can't it ? |
@khancyr |
The Rover thing is more than just adding the So one thing I notice is that set_control_channels in Rover calls functions on the motors library before the motors library is |
8f06b5b
to
1e02384
Compare
I've looked through the Rover change and think moving the set_control_channels should be OK. The calls made in there are configuring ranges and types on input and outputs, which should affect things only in a positive manner. ... still needs to be run on some vehicles. |
I've now put this on a Rover and it didn't cause any fires. |
Functional changes here:
AP_Stats
is initialised after we initialise the serial manager and the GCS console.AP_Stats
doesn't do anything that warrants being initialised before SerialManager, and if things to wrong in stats init it would be good to get diagnostic output (if any)