Plane: Fix RTL behaviour when MIS_RESTART = 1 and DO_LAND_START present. #13652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKear
force-pushed
the
Fix-DO_LAND_START-RTL
branch
from
faaaec9
to
53c93b1
Compare
tridge
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found what I believe to be incorrect behaviour given the following combination:
This series of circumstances leads to the mission always being reset. Thus, instead of RTL causing the aircraft to land via a DO_LAND_START, it causes the mission to begin again from command 1.
This PR fixes this behaviour by adding a _force_resume bool in the mission library. Allowing the invoking mode change back to RTL to effectively ignore the MIS_RESTART parameter in this niche case.
Tested in SITL