AP_Frsky_Telem: fix for protocol=4 GAlt=0 and GSPd=0 #13846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to fill in some of the validators here: https://github.com/ardupilot/ardupilot/blob/master/Tools/autotest/common.py#L4850 Will catch some regressions, at least. |
|
something like tfp_validate_vel_and_yaw(self, value)? EDIT: I created a PR #13850 to test serial protocol 4, and not surprisingly that test would have failed on this code :-) |
peterbarker
approved these changes
Mar 27, 2020
tridge
reviewed
Mar 31, 2020
| @@ -206,11 +206,12 @@ class AP_Frsky_Telem { | |||
| struct | |||
| { | |||
| bool sport_status; | |||
| bool gps_refresh = false; | |||
There was a problem hiding this comment.
we don't need the init of these vars, it just wastes flash
There was a problem hiding this comment.
ok bool initialization fixed
This fixes protocol 4 GPS altitude and speed error, both were reported as constant 0 for cal_gps_position() was never called
yaapu
force-pushed
the
pr-frsky_telem_proto4_fix_galt
branch
from
cb76fe8
to
89fafe3
Compare
|
@yaapu could you rebase the testing PR, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes serial_protocol 4 GPS altitude and speed error, both were reported as constant 0
for calc_gps_position() was never called.
Issue introduced after adding support for VSpd and trying to execute "slow" code when there was no serial input to process.