-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Frsky_Telem: fix for protocol=4 GAlt=0 and GSPd=0 #13846
AP_Frsky_Telem: fix for protocol=4 GAlt=0 and GSPd=0 #13846
Conversation
Would be nice to fill in some of the validators here: https://github.com/ardupilot/ardupilot/blob/master/Tools/autotest/common.py#L4850 Will catch some regressions, at least. |
something like tfp_validate_vel_and_yaw(self, value)? EDIT: I created a PR #13850 to test serial protocol 4, and not surprisingly that test would have failed on this code :-) |
@@ -206,11 +206,12 @@ class AP_Frsky_Telem { | |||
struct | |||
{ | |||
bool sport_status; | |||
bool gps_refresh = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the init of these vars, it just wastes flash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok bool initialization fixed
This fixes protocol 4 GPS altitude and speed error, both were reported as constant 0 for cal_gps_position() was never called
cb76fe8
to
89fafe3
Compare
@yaapu could you rebase the testing PR, please? |
This fixes serial_protocol 4 GPS altitude and speed error, both were reported as constant 0
for calc_gps_position() was never called.
Issue introduced after adding support for VSpd and trying to execute "slow" code when there was no serial input to process.