Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCS_MAVLink: correct response codes when mode change fails #14255

Merged
merged 2 commits into from
Nov 23, 2020
Merged

GCS_MAVLink: correct response codes when mode change fails #14255

merged 2 commits into from
Nov 23, 2020

Commits on Nov 13, 2020

  1. GCS_MAVLink: correct response codes when mode change fails 

    Was "UNSUPPORTED", which is supposed to mean, "Command is not supported"

Now is either "DENIED" (Command is invalid (is supported but has invalid
parameters)) or "FAILED" (Command is valid, but execution has failed.)

We should probably returned DENIED if we try to change to a mode which
doesn't exist, but that would require another callback on AP_Vehicle.
It would also lead to questions around what a valid mode is - so
QSTABILIZE if quadplane is disabled in Plane, for example.
    @peterbarker
    peterbarker committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    0f7f629 View commit details
    Browse the repository at this point in the history

  2. autotest: correct test for mode-change-reason change

    @peterbarker
    peterbarker committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    be46310 View commit details
    Browse the repository at this point in the history