Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON based SITL backend #14392

Merged
merged 6 commits into from
May 28, 2020
Merged

Add JSON based SITL backend #14392

merged 6 commits into from
May 28, 2020

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented May 19, 2020

This is the first steps towards adding support for a JSON based SITL interface.

Still quite a bit of work to do.

  • Fix time-sync issues

- [ ] Send JSON servo rather than binary

  • make tolerant to SITL interface pausing or reseting

- [ ] Improve logging

@IamPete1 IamPete1 requested a review from tridge May 19, 2020 01:16
@IamPete1 IamPete1 added the GSoC Google Summer of Code label May 19, 2020
@IamPete1
Copy link
Member Author

#14384

@IamPete1 IamPete1 force-pushed the JSON_SITL branch 3 times, most recently from 4820154 to 4743211 Compare May 25, 2020 16:16
@IamPete1 IamPete1 force-pushed the JSON_SITL branch 2 times, most recently from e5488f7 to b0c4099 Compare May 25, 2020 21:10
@IamPete1
Copy link
Member Author

I have added the colon formatting for passing in the IP. Also added some documentation in the form of readme's. The MATLAB example is tolerant to SITL stopping and SITL is tolerant to MATLAB stopping, 75% of that is done in MATLAB.

The only outstanding thing its to use a single port for both send and receive and use connect for the socket rather than bind. I had made an attempt at this but failed to get it working.

@IamPete1 IamPete1 marked this pull request as ready for review May 25, 2020 21:35
@rmackay9
Copy link
Contributor

@IamPete1,

FYI, for the GSoC walking robots project we are planning to use PyBullet for a four legged walking robot. @tridge suggests that you might have advice for us on integrating it with SITL. Here's a link to what the walking robot will look like: https://www.instructables.com/id/Synopsis/.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could improve the socket handling, but this is a really great start. Well done!

@tridge tridge merged commit 141ab62 into ArduPilot:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants