-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON based SITL backend #14392
Add JSON based SITL backend #14392
Conversation
4820154
to
4743211
Compare
e5488f7
to
b0c4099
Compare
I have added the colon formatting for passing in the IP. Also added some documentation in the form of readme's. The MATLAB example is tolerant to SITL stopping and SITL is tolerant to MATLAB stopping, 75% of that is done in MATLAB. The only outstanding thing its to use a single port for both send and receive and use connect for the socket rather than bind. I had made an attempt at this but failed to get it working. |
FYI, for the GSoC walking robots project we are planning to use PyBullet for a four legged walking robot. @tridge suggests that you might have advice for us on integrating it with SITL. Here's a link to what the walking robot will look like: https://www.instructables.com/id/Synopsis/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could improve the socket handling, but this is a really great start. Well done!
This is the first steps towards adding support for a JSON based SITL interface.
Still quite a bit of work to do.
- [ ] Send JSON servo rather than binary- [ ] Improve logging