Soaring: Use RCX_OPTION #14815
Merged
Soaring: Use RCX_OPTION #14815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR for wiki update is here |
|
thanks! |
magicrub
previously requested changes
Jul 15, 2020
peterbarker
reviewed
Jul 16, 2020
There was a problem hiding this comment.
The title of this PR is kind of bad; the change to using a channel option is excellent, but kind of besides the point of this PR.
Changing to use the channel option should be a straight-forward change - the changes in the soaring library are rather non-trivial :-)
The changes don't look too intertwined - is it reasonable to split this into two PRs?
samuelctabor
force-pushed
the
pr/soar-rcx-option
branch
2 times, most recently
from
43f78cc
to
5694f38
Compare
|
I have dropped the refactor to make this one easier to review as Peter suggested. I'll open a separate PR for that. |
|
On Thu, 16 Jul 2020, Samuel Tabor wrote:
Looks like DISABLED has been expanded as a macro to 0?
Yup. One of the nastier wrinkles in our codebase; "ENABLED" and
"DISABLED" are defined in the vehicle's defines.h which pollutes
*everything*.
|
peterbarker
approved these changes
Jul 17, 2020
samuelctabor
force-pushed
the
pr/soar-rcx-option
branch
from
5694f38
to
c459d28
Compare
|
Thanks, now squashed. |
tridge
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies soaring.cpp somewhat and converts from using SOAR_ENABLE_CH to having soaring as a RC option. The parameter is converted if configured.