Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #14423 and removes the gyro pre-filter that is applied in the ICM drivers.
There are a few reasons for doing this:
So although removing the filter will inevitably add some noise. The question is - does it matter?
I ran tests with a gyro rate of 2kHz on an MPU6000 with/without and with double-notches. I picked 2kHz here because this was the frequency at which the differences were most evident. These were the results:
Standard:
![image](https://user-images.githubusercontent.com/2893260/88335272-f0c53d00-cd2a-11ea-9e8a-f837fb93d797.png)
No pre-filter:
![image](https://user-images.githubusercontent.com/2893260/88335308-033f7680-cd2b-11ea-8193-eff549292568.png)
No pre-filter, double notches:
![image](https://user-images.githubusercontent.com/2893260/88335347-12bebf80-cd2b-11ea-88d6-3a079f74aac0.png)
A few things to note:
Note to reviewers - this is actually a two-line change, most of the changes are in #14423