-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make camera mount and solo gimbal board configured features #14899
Conversation
I love this ! |
27f021f
to
d9c1dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small change to make solo gimbal off by default, and enabled on 2M boards
…ble Solo gimbal on all 1MB boards
d9c1dd1
to
81120c7
Compare
81120c7
to
57c6afd
Compare
So this looks like it is enabled by default and disabled in hwdef where specifically not wanted? Would it be even better to disable the solo gimbal by default, requiring it to be enabled in the hwdef? That can be enabled for the solo's build target hwdef files only. And not exist in all the rest that don't need it. |
@Pedals2Paddles it's disabled by default on all 1Mb boards - see AP_Mount.h |
I see where it's disabled on the 1MB boards. I'm not seeing where it is actually defined as enabled to begin with? I'm actually suggesting we save the flash space on all boards by only enabling the Solo gimbal in the hwdef files for the build targets for the Solo. |
It's enabled on 2MB boards in AP_Mount.h. But happy to disable everywhere if you can give me the list where it should be enabled? |
Just a comment here I have a copter that is not a solo that has a solo gimbal installed. I personally would like to see it stay on 2M boards |
This PR saves a ton of flash:
Saves 18k flash on the 1mB boards
Saves 24k flash on the mini boards