New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove AP_MotorsMatrixTS #15020
remove AP_MotorsMatrixTS #15020
Conversation
Hi, do we need any changes for the parameter descriptions or is that all done on the Plane side? |
I should have been saying frame_type above, instead of frame_class. |
@kd0aij, Probably both leaving it out of the parameter description and making it unavailable for the Copter firmware makes sense. |
Would you prefer a pre-arm check or the #if approach in MotorsMatrix? |
@kd0aij, I think if some #ifs are added then an existing pre-arm check will catch that the motor driver hasn't been initialised successfully. |
8aa3f1b
to
1698dde
Compare
Restricted frame_types 17,18 to ArduPlane builds |
there were only two frame types unique to copter tailsitters, and the simplified implementation of function AP_MotorsMatrixTS::output_armed_stabilizing appears to be unnecessary
@rmackay9 This just absorbs support for the 2 quad-no-yaw-torque frame types used by copter tailsitters into AP_MotorsMatrix, and should have no functional impact on any other frame type.