Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL: add apparent speed, AP_WindVane backend and support in JSON interface #15061

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

IamPete1
Copy link
Member

No description provided.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a lot of change, previous behavior is maintained.
Maybe the naming is a bit confusing, but I don't know the term on windvane world. Maybe we could use NED and BODY to be consistant, or relative/global ?

@@ -105,6 +109,8 @@ class JSON : public Aircraft {
{ "", "rng_4", &state.rng[3], DATA_FLOAT, false },
{ "", "rng_5", &state.rng[4], DATA_FLOAT, false },
{ "", "rng_6", &state.rng[5], DATA_FLOAT, false },
{"windvane","direction", &state.wind_vane_apparent.direction, DATA_FLOAT, false},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be just airspeed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory Yes, but there is no reason we cant have both, I think this avoids confusion.

@tridge tridge merged commit 8aeee4b into ArduPilot:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants