Plane: always output flaperons and dspoilers #15673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelctabor thoughts? |
|
I read the current flaperon check as "output if at least one flaperon is set up". Makes sense to save cycles if flaperons aren't being used. Maybe the dspoiler check should similarly check at least one dspoiler is set up, rather than just k_dspoilerLeft1? |
tridge
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the checks for both flaperons to be setup before outputting flaperons, and the check for dspoiler left 1 before outputting dspoilers.
Not really a issue for flying but this often confuses people while they are setting up.