AP_MSP: fix for multiple backends initialization #15757
Conversation
| @@ -102,7 +102,7 @@ void AP_MSP::init() | |||
| for (uint8_t protocol_instance=0; protocol_instance<MSP_MAX_INSTANCES-_msp_status.backend_count; protocol_instance++) { | |||
There was a problem hiding this comment.
insn't the issue just :
for (uint8_t protocol_instance=_msp_status.backend_count; protocol_instance<MSP_MAX_INSTANCES; protocol_instance++)
There was a problem hiding this comment.
mhmm I don't think so, shouldn't we check each serial protocol for all instances starting at 0 up to the MAX allowed?
| @@ -86,7 +86,7 @@ void AP_MSP::init() | |||
| for (uint8_t protocol_instance=0; protocol_instance<MSP_MAX_INSTANCES; protocol_instance++) { | |||
There was a problem hiding this comment.
if we don't use the protocol_instance variable, maybe using
| for (uint8_t protocol_instance=0; protocol_instance<MSP_MAX_INSTANCES; protocol_instance++) { | |
| while (_msp_status.backend_count < MSP_MAX_INSTANCES) { |
would be better ?
There was a problem hiding this comment.
@khancyr I refactored and removed backend_instance, now should be ok. It loops thru all instances per each serial protocol starting from instance 0 up to MAX instances accounting for already found backends. But is suboptimal 'cause it still looks for instance 1 even if instance 0 was not found, maybe the extra variable was needed after all
yaapu
force-pushed
the
pr/msp_fix_multiple_backends
branch
from
46f1b4f
to
7190790
Compare
A fix for multiple MSP backends initialization.
related issue #15756