Replay: added --force-ekf2 and --force-ekf3 #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even when one is disabled in the original log
avoids need for -- arguments for replay
this facilitates --force-ekf2 and --force-ekf3
allows for --force-ekf2 and --force-ekf3 to run the other EKFs events when needed
khancyr
reviewed
Nov 16, 2020
| @@ -287,7 +288,7 @@ void SITL_State::_parse_command_line(int argc, char * const argv[]) | |||
|
|
|||
| GetOptLong gopt(argc, argv, "hwus:r:CI:P:SO:M:F:c:", | |||
| options); | |||
| while ((opt = gopt.getoption()) != -1) { | |||
| while (!is_replay && (opt = gopt.getoption()) != -1) { | |||
There was a problem hiding this comment.
Maybe just nitpicking, but can't we just move the if (is_replay) here and put the while loop into the the else cause ?
That would also have the advantage to allow us to define another parser for the SITL replay configuration
peterbarker
approved these changes
Nov 17, 2020
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.