Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: make build installation script compatible with most Linux distros - 2 #16410

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Jan 21, 2021

Rework from #15726

use apt-cache first as it is recommended on Ubuntu based system and the dpkg-query can return wrongly false.

Fix lsb_release check.

Tested on Ubuntu 18.04/20.04/20.10 and Debian buster

@AbhishekJoshi
Copy link

Hi quick question -- will change be compatible for pxfmini boards, on newer versions of Copter? (make pxfmini -j4 is what I use)

@magicrub
Copy link
Contributor

magicrub commented Mar 4, 2021

Hi quick question -- will change be compatible for pxfmini boards, on newer versions of Copter? (make pxfmini -j4 is what I use)

@AbhishekJoshi you could hope he/sh we knows/tests or, of you're willing, checkout the branch and test for yourself

@khancyr
Copy link
Contributor Author

khancyr commented Mar 5, 2021

@AbhishekJoshi this change quite nothing for specific board. If your OS is older that ubuntu 16.04, the installation is probably broken and we won't fix it. And we don't support make build for long time

@tridge
Copy link
Contributor

tridge commented Mar 17, 2021

pending CI

@peterbarker peterbarker merged commit 311a4ed into ArduPilot:master Mar 17, 2021
@peterbarker
Copy link
Contributor

Merged, thanks!

@khancyr khancyr deleted the pr/15726 branch March 17, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants