Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Does size matter ? #16597

Merged
merged 2 commits into from
Mar 3, 2021
Merged

CI: Does size matter ? #16597

merged 2 commits into from
Mar 3, 2021

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Feb 11, 2021

Rework from #15702

It compiles master branch back, get the binaries for some boards, rebase the PR on top of master, build the binaries, use Bloaty to compare the binaries

PS: Only the taste matter ;-P

@tridge
Copy link
Contributor

tridge commented Feb 15, 2021

Bloaty to compare the binaries

why do we want bloaty? What we want is to change in size of the bin file, not the elf (so it handles things like changes in embedded ROMFS).
Comparing the size of two bin files is a couple of lines of shell script

@khancyr
Copy link
Contributor Author

khancyr commented Feb 16, 2021

reworked without bloaty
example output

Tools/scripts/pretty_diff_size.py -m second -s build/sitl/bin
Extracting binaries size on second
Get binary size of second/arducopter-heli
Get binary size of second/ardusub
Get binary size of second/antennatracker
Get binary size of second/ardurover
Get binary size of second/arducopter
Get binary size of second/arduplane
Success !
Extracting binaries size on build/sitl/bin
Get binary size of build/sitl/bin/arducopter-heli
Get binary size of build/sitl/bin/ardusub
Get binary size of build/sitl/bin/antennatracker
Get binary size of build/sitl/bin/ardurover
Get binary size of build/sitl/bin/arducopter
Get binary size of build/sitl/bin/arduplane
Success !

Binary           text             data         bss          total
---------------  ---------------  -----------  -----------  ---------------
arducopter-heli  1624 (+0.0375%)  0 (0.0000%)  0 (0.0000%)  1624 (+0.0349%)
ardusub          1816 (+0.0470%)  0 (0.0000%)  0 (0.0000%)  1816 (+0.0438%)
antennatracker   1640 (+0.0486%)  0 (0.0000%)  0 (0.0000%)  1640 (+0.0451%)
ardurover        1752 (+0.0445%)  0 (0.0000%)  0 (0.0000%)  1752 (+0.0413%)
arducopter       792 (+0.0181%)   0 (0.0000%)  0 (0.0000%)  792 (+0.0169%)
arduplane        1768 (+0.0410%)  0 (0.0000%)  0 (0.0000%)  1768 (+0.0381%)

@khancyr khancyr force-pushed the size_matter branch 2 times, most recently from 458928b to 0d02cf7 Compare February 17, 2021 07:58
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI passing

@amilcarlucas
Copy link
Contributor

CI pass. Can it be merged?

@tridge tridge merged commit ada6649 into ArduPilot:master Mar 3, 2021
@khancyr khancyr deleted the size_matter branch March 3, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants