AP_Filesystem: allow transfer of mission/fence/rally/param with mavftp #17102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-mavftp-mission
branch
from
9f0b283
to
fcb8a5a
Compare
tridge
force-pushed
the
pr-mavftp-mission
branch
2 times, most recently
from
9c7fd6d
to
c314060
Compare
magicrub
reviewed
Apr 7, 2021
tridge
changed the title
tridge
force-pushed
the
pr-mavftp-mission
branch
2 times, most recently
from
b8a7c51
to
1998e2d
Compare
tridge
changed the title
|
I've had a look through this, like @magicrub , and it looks pretty clean to me. I'd be more comfortable with all the low-level filesystem functionality being correct if it had auto-tests that exercised all the upload/download and compared the before-upload and the after-download, etc, but that's just me, i know auto-tests aren't really considered 'essential' at this point. |
andyp1per
approved these changes
Apr 20, 2021
this allows for the @mission filesystem to download data in the current mavlink format
not all HALs zero memory on realloc
thanks Andy!
tridge
force-pushed
the
pr-mavftp-mission
branch
from
1998e2d
to
1de5337
Compare
what I'd like to do is make the whole mavlink ftp support conditional, and allow disable of it in the custom fw server |
good call btw, there was a socket write of uninitialised memory, fixed now |
andyp1per
approved these changes
Apr 20, 2021
overflowing by 1k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a @mission filesystem for upload and download of mission/fence/rally and extends @param filesystem for parameter upload with ftp
mavproxy implementation: ArduPilot/MAVProxy#880
working: