Tools: update default params for copter-optflow.parm #17590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
reviewed
May 28, 2021
| @@ -1,6 +1,8 @@ | |||
| ARMING_CHECK -33 | |||
| EKF_GPS_TYPE 3 | |||
| ARMING_CHECK 786390 | |||
| EK2_GPS_TYPE 3 | |||
There was a problem hiding this comment.
why keep this one when we are on EKF3 ?
There was a problem hiding this comment.
Yes, indeed, we could remove these parameters that are already set to these values by default.
tridge
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the copter-optflow.parm file which makes setting up optical flow for use in SITL. This is not actually used by any autotests.
This was tested in SITL:
By the way, this change leaves the GPS enabled which means the EKF's origin is set without the user having to do it manually.