create a HAL_QUADPLANE_ENABLED define #17941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/hal-quadplane-enabled
branch
from
41db45c
to
c6ab020
Compare
tridge
reviewed
Sep 8, 2021
ArduPlane/navigation.cpp
Outdated
| (control_mode == &mode_rtl && quadplane.available() && quadplane.rtl_mode == QuadPlane::RTL_MODE::SWITCH_QRTL)) { | ||
| current_loc.get_distance(next_WP_loc) > radius*3) | ||
| #if HAL_QUADPLANE_ENABLED | ||
| || (control_mode == &mode_rtl && quadplane.available() && quadplane.rtl_mode == QuadPlane::RTL_MODE::SWITCH_QRTL) |
There was a problem hiding this comment.
IF_QUADPLANE()
IF_QUADPLANE(control_mode == &mode_rtl && quadplane.available() && quadplane.rtl_mode == quadPlane::RTL_MODE::SWITCH_QRTL)
#if HAL_QUADLPLANE_ENABLE
#define IF_QUADPLANE(x) (x)
#18540
#define IF_QUADPLANE(x) (false)
#endif
peterbarker
force-pushed
the
pr/hal-quadplane-enabled
branch
2 times, most recently
from
4187197
to
fe3e6eb
Compare
peterbarker
force-pushed
the
pr/hal-quadplane-enabled
branch
3 times, most recently
from
a30c108
to
53bd2cb
Compare
tridge
approved these changes
Sep 13, 2021
peterbarker
force-pushed
the
pr/hal-quadplane-enabled
branch
from
53bd2cb
to
cfb40ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely invasive patch.
I think it's worth considering creating a quadplane dummy object instead of modifying all the places
quadplane.is used. Still have the define, 'though.