Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove safe PWM #18495

Merged
merged 7 commits into from
Sep 13, 2021
Merged

Remove safe PWM #18495

merged 7 commits into from
Sep 13, 2021

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Aug 29, 2021

Follow up to #18050 This removes the setting of safety PWM from rover, it is the last user so the functionality is then removed from the rest of the code.

Safe PWM should always be 0, if you want it to be PWM min then you should let that channel past BRD_SAFTY_MASK. We had numerous issues related to this on plane, although I don't think we have one for rover. People assume 'safe' means safe and that were not outputting to motor, currently you can change PWM trim and get motors to spin in safe mode.

Saves 64 bytes on the io-firmware

@khancyr
Copy link
Contributor

khancyr commented Aug 29, 2021

It think that the only case we need this was the use of petrol engine, so if we got an alternative that is fine !

@tridge
Copy link
Contributor

tridge commented Aug 31, 2021

needs testing with new IO fw loaded on a board with IOMCU

@IamPete1
Copy link
Member Author

IamPete1 commented Sep 4, 2021

I have tested on a CubeOrange, all seems to work as expected. No errors in the log. Outputs work and are disabled/enabled correctly with the safety mask.

@tridge
Copy link
Contributor

tridge commented Sep 8, 2021

need to rebuild and test IO with new 10.2 compiler (apparently this was with 7.5)

@tridge
Copy link
Contributor

tridge commented Sep 8, 2021

need to test OVERRIDE_CHAN, or BRD_OPTIONS=0 and crash FMU using the lockup_autopilot command in mavproxy

@tridge tridge removed the DevCallEU label Sep 8, 2021
@IamPete1
Copy link
Member Author

All seems to work as expected. I did use the correct compiler version, must have checked WSL1 and not WSL2 on the EU call.

/opt/gcc-arm-none-eabi-10-2020-q4-major/bin/arm-none-eabi-size

There is no diff after a re-compile of the IO firmware.

I tested master and then this using OVERRIDE_CHAN on plane. Outputs switch as expected, you can tell because the throttle is no longer suppressed in override.

@tridge tridge merged commit 09b26e4 into ArduPilot:master Sep 13, 2021
@IamPete1 IamPete1 deleted the remove_safe_pwm branch September 14, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants