-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove safe PWM #18495
Remove safe PWM #18495
Conversation
It think that the only case we need this was the use of petrol engine, so if we got an alternative that is fine ! |
needs testing with new IO fw loaded on a board with IOMCU |
I have tested on a CubeOrange, all seems to work as expected. No errors in the log. Outputs work and are disabled/enabled correctly with the safety mask. |
need to rebuild and test IO with new 10.2 compiler (apparently this was with 7.5) |
need to test OVERRIDE_CHAN, or BRD_OPTIONS=0 and crash FMU using the lockup_autopilot command in mavproxy |
All seems to work as expected. I did use the correct compiler version, must have checked WSL1 and not WSL2 on the EU call.
There is no diff after a re-compile of the IO firmware. I tested master and then this using |
Follow up to #18050 This removes the setting of safety PWM from rover, it is the last user so the functionality is then removed from the rest of the code.
Safe PWM should always be 0, if you want it to be PWM min then you should let that channel past
BRD_SAFTY_MASK
. We had numerous issues related to this on plane, although I don't think we have one for rover. People assume 'safe' means safe and that were not outputting to motor, currently you can change PWM trim and get motors to spin in safe mode.Saves 64 bytes on the io-firmware