New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Arming: check min heater temp #18640
Changes from all commits
0ed164f
d8b1f4c
dc0b89d
7875fc0
b9afb30
1ad25c2
78171a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,10 @@ | |
#define HAL_IMU_TEMP_DEFAULT -1 // disabled | ||
#endif | ||
|
||
#ifndef HAL_IMU_TEMP_MARGIN_LOW_DEFAULT | ||
#define HAL_IMU_TEMP_MARGIN_LOW_DEFAULT 0 // disabled | ||
#endif | ||
|
||
#ifndef BOARD_SAFETY_OPTION_DEFAULT | ||
# define BOARD_SAFETY_OPTION_DEFAULT (BOARD_SAFETY_OPTION_BUTTON_ACTIVE_SAFETY_OFF|BOARD_SAFETY_OPTION_BUTTON_ACTIVE_SAFETY_ON) | ||
#endif | ||
|
@@ -306,6 +310,16 @@ const AP_Param::GroupInfo AP_BoardConfig::var_info[] = { | |
AP_GROUPINFO("ALT_CONFIG", 22, AP_BoardConfig, _alt_config, 0), | ||
#endif // HAL_PIN_ALT_CONFIG | ||
|
||
#if HAL_HAVE_IMU_HEATER | ||
// @Param: TEMPMGN_LOW | ||
// @DisplayName: hearter temp lower margin | ||
// @Description: Arming check will fail if IMU temp is more than this value lower than BRD_IMU_TARGTEMP, 0 disables | ||
// @Range: 0 20 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if maybe the acceptable range should be larger? Surely 30deg range is also OK in some cases? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course, 30 will work, but if accepting 30 deg lower than target temp your might as well just switch of the check all-together. if your heater is never reaching the target temp the solution should be to reduce the target temp rather than the arming threshold. |
||
// @Units: degC | ||
// @User: Advanced | ||
AP_GROUPINFO("TEMPMGN_LOW", 23, AP_BoardConfig, heater.imu_arming_temperature_margin_low, HAL_IMU_TEMP_MARGIN_LOW_DEFAULT), | ||
#endif | ||
|
||
AP_GROUPEND | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hearter"..