APM_Control: only save autotune gains when P finished #18883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-plane-autotune-save-fix
branch
from
661af01
to
2472ed5
Compare
peterbarker
requested changes
Oct 9, 2021
this prevents saving values which are temporarily high due to tuning process See this bug report https://discuss.ardupilot.org/t/plane-4-1-0-stable/76507/45
tridge
force-pushed
the
pr-plane-autotune-save-fix
branch
from
2472ed5
to
bcc227f
Compare
peterbarker
approved these changes
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents saving values which are temporarily high due to tuning process. The temporary values can be very large and lead to oscillations. The bug is particularly serious as the issue doesn't show up until after the next power cycle, which could be days later. You end up with the wrong PID gains, taken from an intermediate (and potentially unstable) stage of the tune
See this bug report
https://discuss.ardupilot.org/t/plane-4-1-0-stable/76507/45