Plane: support send_extended_sys_state #19137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
plane_sys_status
branch
from
c351242
to
5c686ef
Compare
|
Seems to work, tested both SLT and tailsitters using: |
IamPete1
commented
Nov 3, 2021
| { | ||
| if (quadplane.in_vtol_mode()) { | ||
| QuadPlane::position_control_state state = quadplane.poscontrol.get_state(); | ||
| if ((state == QuadPlane::position_control_state::QPOS_AIRBRAKE) || (state == QuadPlane::position_control_state::QPOS_POSITION1)) { |
There was a problem hiding this comment.
might want to limit this to only be QPOS_AIRBRAKE we can sometimes spend a while repositioning in QPOS_POSITION1
peterbarker
approved these changes
Nov 4, 2021
khancyr
approved these changes
Nov 4, 2021
| #endif | ||
| }; | ||
|
|
||
| MAV_LANDED_STATE GCS_MAVLINK_Plane::landed_state() const |
There was a problem hiding this comment.
we could work the takeoff and landing state later
|
The original PR from @peterbarker did have some auto tests. I guess they should still work..... |
|
yep, that is why I asked ! specially when the vtol transition seems tricky |
tridge
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #10698 now we have separate translation logic.