hwdef: added CarbonixL496 AP_Periph node #19364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-canbonix-cx1304
branch
from
1924692
to
027bf25
Compare
actuator IDs are tied to OUTn_FUNCTION, not to physical output IDs, so it is perfectly possible for an actuator ID to be larger than the number of PWM outputs on the board
tridge
force-pushed
the
pr-canbonix-cx1304
branch
from
027bf25
to
487b394
Compare
peterbarker
approved these changes
Dec 6, 2021
andyp1per
reviewed
Dec 7, 2021
| @@ -298,7 +298,7 @@ const AP_Param::Info AP_Periph_FW::var_info[] = { | |||
| // @Param: ESC_PWM_TYPE | |||
| // @DisplayName: Output PWM type | |||
| // @Description: This selects the output PWM type, allowing for normal PWM continuous output, OneShot, brushed or DShot motor output | |||
| // @Values: 0:Normal,1:OneShot,2:OneShot125,3:Brushed,4:DShot150,5:DShot300,6:DShot600,7:DShot1200 | |||
| // @Values: 1:Normal,2:OneShot,3:OneShot125,4:Brushed,5:DShot150,6:DShot300,7:DShot600,8:DShot1200 | |||
There was a problem hiding this comment.
Doesn't this mean PWM isn't supported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes: