Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: added yaw rate control PID #19365

Merged
merged 10 commits into from
Nov 30, 2021
Merged

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Nov 25, 2021

This adds PID parameters for a yaw rate controller for ACRO mode. It is intended to be used for the fixed wing aerobatics supports, but may be useful for ACRO pilots

To enable for ACRO mode, set ACRO_YAW_RATE to desired maximum rate in degrees/second, and set YAW_RATE_ENABLE=1 to enable PID tuning of yaw rate controller

pair programmed with Andy Palmer and Matthew Hampsey

@IamPete1
Copy link
Member

Any thoughts on using this for Rover on boats with rudders? Should be an improvement over the way speed scaling is done currently. Great to see this enhancement!

@tridge
Copy link
Contributor Author

tridge commented Nov 26, 2021

Any thoughts on using this for Rover on boats with rudders?

I haven't looked at it, but it should work I think
the SCRIPT_TIME stuff would be fun for fast motor boats :-)

@tridge
Copy link
Contributor Author

tridge commented Nov 26, 2021

@IamPete1 a review would also be welcome so I can get this merged :-)

ArduPlane/Parameters.cpp Outdated Show resolved Hide resolved
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of very minor comments but basically looks good.

@andypnz
Copy link
Contributor

andypnz commented Nov 27, 2021

Working great in SITL. Hope to test in a plane soon :-)

@andypnz
Copy link
Contributor

andypnz commented Nov 28, 2021

Yaw autotune and the yaw rate controller working great out at the flying field :-) Successful rolling circle with the MXS foamy no problems at all!

Copy link
Contributor

@priseborough priseborough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the dependency on the value of the _RATE_ENABLE param is noted in the ACRO_YAW_RATE parameter description and the default yaw rate control parameter values are safe to use with a powerful rudder plane like the PA Addiction X, then this should be OK to merge given it is an advanced feature that is off by default.

@priseborough priseborough self-requested a review November 28, 2021 06:53
Copy link
Contributor

@priseborough priseborough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the dependency on the value of the _RATE_ENABLE param is noted in the ACRO_YAW_RATE parameter description and the default yaw rate control parameter values are OK to use with a powerful rudder plane like the PA Addiction X, then this should be OK to merge given it is an advanced feature that is off by default.

@peterbarker peterbarker merged commit c83da81 into ArduPilot:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants