-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: added yaw rate control PID #19365
Conversation
7a656f9
to
95cb996
Compare
Any thoughts on using this for Rover on boats with rudders? Should be an improvement over the way speed scaling is done currently. Great to see this enhancement! |
I haven't looked at it, but it should work I think |
@IamPete1 a review would also be welcome so I can get this merged :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor comments but basically looks good.
Working great in SITL. Hope to test in a plane soon :-) |
Yaw autotune and the yaw rate controller working great out at the flying field :-) Successful rolling circle with the MXS foamy no problems at all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the dependency on the value of the _RATE_ENABLE param is noted in the ACRO_YAW_RATE parameter description and the default yaw rate control parameter values are safe to use with a powerful rudder plane like the PA Addiction X, then this should be OK to merge given it is an advanced feature that is off by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the dependency on the value of the _RATE_ENABLE param is noted in the ACRO_YAW_RATE parameter description and the default yaw rate control parameter values are OK to use with a powerful rudder plane like the PA Addiction X, then this should be OK to merge given it is an advanced feature that is off by default.
enabled with YAW_RATE_ENABLE parameter
to enable for ACRO mode, set ACRO_YAW_RATE to desired maximum rate in degrees/second, and set YAW_RATE_ENABLE=1 to enable PID tuning of yaw rate controller pair programmed with Andy Palmer and Matthew Hampsey
this uses the new yaw rate controller to do EF tracking, so we follow towards the next WP while doing the roll
6d45b7d
to
4af2c59
Compare
This adds PID parameters for a yaw rate controller for ACRO mode. It is intended to be used for the fixed wing aerobatics supports, but may be useful for ACRO pilots
To enable for ACRO mode, set ACRO_YAW_RATE to desired maximum rate in degrees/second, and set YAW_RATE_ENABLE=1 to enable PID tuning of yaw rate controller
pair programmed with Andy Palmer and Matthew Hampsey