Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_GPS: drop default GPS lag to 0.1s #19656

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Jan 3, 2022

this impacts UAVCAN GPS modules, which these days usually have at
least u-blox M8

this impacts UAVCAN GPS modules, which these days usually have at
least u-blox M8
@tridge tridge added the GPS label Jan 3, 2022
Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on matek M8Q it is 0.11 (MSP backend), on Ublox backend it is at 0.12, now you said 0.1
Shouldn't we harmonized all those ?

@tridge
Copy link
Contributor Author

tridge commented Jan 3, 2022

Shouldn't we harmonized all those ?

ublox varies with sensor type. 100ms is a compromise when we don't know sensor type. Ideally we would detect the text message from the CAN GPS giving the sensor type and set based on that, but this is a better value than we have now. When we chose 220ms the "normal" GPS was M6 or worse. Lag is a lot better now.

@khancyr
Copy link
Contributor

khancyr commented Jan 4, 2022

Ok, no problem. I was just surprised by the differences for the same ublox

@magicrub magicrub merged commit 1e60d25 into ArduPilot:master Jan 4, 2022
@IamPete1
Copy link
Member

IamPete1 commented Jan 4, 2022

This broke CI in some odd ways, seems to create a interesting status text race condition.

#19675

@hendjoshsr71
Copy link
Member

Specific tests failing are test.Plane.DCMFallback & test.Rover.GripperMission

@rmackay9 rmackay9 added this to pending in Copter 4.1 Jan 27, 2022
@rmackay9 rmackay9 moved this from pending to 4.1.4-rc1 in Copter 4.1 Jan 27, 2022
@tridge tridge added this to Done in Plane 4.1 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Copter 4.1
4.1.4-rc1
Rover 4.1
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

6 participants