AP_BatteryMonitor: add current scaler for UAVCAN #19791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but that only works for analog sensors and would still be needed to be changed for other sensors....adding CUR_ADJUST to I2C and SMBUS may make sense, but until someone has issues, why bother? this is really because CUAV did not expose the cal params....Pomegranate does in their UAVCAN PM.... |
|
Yeah it is unfortunate on CUAVs part. Probably, this is fine for now.... and of course easier. And imagine we will go with it. The only question is that the change to move the relevant parameters to analog only are in master only. Meaning we could back that out before the Beta coming up very fast....? And add in the adjustments to the other monitors. |
tridge
requested changes
Jan 18, 2022
rmackay9
reviewed
Jan 18, 2022
Hwurzburg
force-pushed
the
current_adjust
branch
from
1a94157
to
bff6a20
Compare
hendjoshsr71
approved these changes
Jan 20, 2022
tridge
approved these changes
Jan 24, 2022
rmackay9
reviewed
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tweaking UAVCAN PMs that do not provide a param for current adjustment (ie CUAV for example) and also allows lower capacity monitors to be used in parallel battery setups by attaching to one of the paralleled batteries
tested on CUAV UAVCAN power module
thanks to @hendjoshsr71 for helping me debug the constructs