diff binaries as part of CI #19805
Merged
diff binaries as part of CI #19805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
building AP_Periph requires these to be able to be converted into a number
This allows for reproducible builds to be produced
If a change is not supposed to change build outcomes this will help show it
khancyr
reviewed
Jan 16, 2022
|
@khancyr that would save about 34 seconds per item in the matrix. I put the timings into this PR so we could debate just this point :-) I didn't want to modify the original test (build a board just as a normal person would), as it's a really base-line test which we don't want to break. It's possible but not likely that we could break the builds if you didn't specify these git hashes. The other reason I left the includes-real-git-hashes build in is that you can download the binaries as artifacts, and I think it would be important at that point to have the git hash in them so you can recognise them and where they came from later. |
tridge
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to be assured that there's no changes from a PR, at least for things we test in CI; if the binaries are identical the functionality is identical.
I've tested the changes to the waf build by creating another commit on top of this PR and ensured that the output files have the same checksum before/after (they don't on master).
The binaries on this PR won't match master (i.e. the diff will show differences) as master doesn't have the patches to use a known git hash.