Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logging of Event::SET_HOME up to AP_AHRS #19931

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Move logging of Event::SET_HOME up to AP_AHRS #19931

merged 4 commits into from
Feb 8, 2022

Conversation

peterbarker
Copy link
Contributor

Tested in SITL. Event is still logged:

MAV> messages SET_HOME
MAV> 2022-01-30 16:53:02.426 Event: DATA_SET_HOME

amilcarlucas
amilcarlucas reviewed Jan 30, 2022
View reviewed changes
Copy link
Contributor

@amilcarlucas amilcarlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess Rover and Plane log it now as well?

@peterbarker
Copy link
Contributor Author

So I guess Rover and Plane log it now as well?

Correct. And Tracker :-P

hendjoshsr71
hendjoshsr71 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@hendjoshsr71 hendjoshsr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tridge tridge merged commit 2ef0975 into ArduPilot:master Feb 8, 2022
@peterbarker peterbarker deleted the pr/move-log-home-was-setup-up branch February 8, 2022 00:14
@IamPete1 IamPete1 removed the DevCallEU label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilcarlucas amilcarlucas amilcarlucas left review comments

@tridge tridge tridge approved these changes

@hendjoshsr71 hendjoshsr71 hendjoshsr71 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@peterbarker @tridge @amilcarlucas @hendjoshsr71 @CraigElder @IamPete1