Copter/Plane: Judge by return value #20057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm tempted to close this as it doesn't make a material difference and the compiler removes the extra variable anyway. (Thus the zero size change.)
It doesn't really change the clarity of the code for the better or worse. It does add one more step during debugging though.
@rmackay9 is the code style master though so his call?
hendjoshsr71
requested changes
Feb 14, 2022
| @@ -294,8 +293,7 @@ void Copter::parachute_check() | |||
| parachute.check_sink_rate(); | |||
|
|
|||
| // check for angle error over 30 degrees | |||
| const float angle_error = attitude_control->get_att_error_angle_deg(); | |||
| if (angle_error <= PARACHUTE_CHECK_ANGLE_DEVIATION_DEG) { | |||
| if (attitude_control->get_att_error_angle_deg() <= CRASH_CHECK_ANGLE_DEVIATION_DEG) { | |||
There was a problem hiding this comment.
This doesn't look right...
Suggested change
| if (attitude_control->get_att_error_angle_deg() <= CRASH_CHECK_ANGLE_DEVIATION_DEG) { | |
| if (attitude_control->get_att_error_angle_deg() <= PARACHUTE_CHECK_ANGLE_DEVIATION_DEG) { |
|
this doesn't look like an improvement and makes debugging harder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The angle_error variable is used only once.
I make the decision in the return value of the method, which eliminates the need for this variable.