Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mode_auto.cpp #20153

Closed
wants to merge 3 commits into from
Closed

Update mode_auto.cpp #20153

wants to merge 3 commits into from

Conversation

Hasi123
Copy link

@Hasi123 Hasi123 commented Feb 23, 2022

Change to relative frame to avoid terrain bug with takeoff. Fixes #20142

Change to relative frame to avoid terrain bug with takeoff.
@muramura
Copy link
Contributor

I think that when I create an automatic plan, I should just check the flight in the simulation.

@Hasi123
Copy link
Author

Hasi123 commented Feb 24, 2022

I have tested it yesterday in the simulator and today on my own copter. Works just as expected. Here are some logs (before/after behaviour):
logs_before_after_fix.zip

Should/could also be backported to 4.1, nut sure how to request this on GitHub.

ArduCopter/mode_auto.cpp Outdated Show resolved Hide resolved
@tridge
Copy link
Contributor

tridge commented Mar 1, 2022

assigned to @rmackay9

Hasi123 and others added 2 commits March 1, 2022 07:35
Petes suggestion for clearer code

Co-authored-by: Peter Hall <33176108+IamPete1@users.noreply.github.com>
@rmackay9
Copy link
Contributor

I've got an updated fix here #20285. @Hasi123 would you be able to confirm this resolves the issue you've seen? Thanks again for finding this important bug!

@rmackay9 rmackay9 closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copter: Sudden jump in desired altitude when switching to auto
6 participants