Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: added RTL_AUTOLAND=3 #20345

Merged
merged 1 commit into from Mar 23, 2022
Merged

Plane: added RTL_AUTOLAND=3 #20345

merged 1 commit into from Mar 23, 2022

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Mar 22, 2022

this allows for easy disabling of the new arming check

@IamPete1
Copy link
Member

There is a command long too.

case MAV_CMD_DO_LAND_START:
// attempt to switch to next DO_LAND_START command in the mission
if (plane.mission.jump_to_landing_sequence()) {
plane.set_mode(plane.mode_auto, ModeReason::GCS_COMMAND);
return MAV_RESULT_ACCEPTED;
}
return MAV_RESULT_FAILED;

For 4.3 I would like to get "auto RTL" mode into plane to match copter, that will remove the RTL_AUTOLAND param.

@WickedShell
Copy link
Contributor

WickedShell commented Mar 22, 2022 via email

@tridge
Copy link
Contributor Author

tridge commented Mar 22, 2022

@WickedShell you can just set RTL_AUTOLAND to -1
I'll raise this for EU dev call, possibly drop this PR and create a value for -1 for RTL_AUTOLAND

@tridge
Copy link
Contributor Author

tridge commented Mar 23, 2022

i've added a RTL_AUTOLAND=3 to disable the warning

@tridge tridge added WikiNeeded needs wiki update and removed DelayMerge labels Mar 23, 2022
@tridge tridge changed the title Plane: only apply DO_LAND_START arming check on quadplanes Plane: added RTL_AUTOLAND=3 Mar 23, 2022
set RTL_AUTOLAND=3 to get go-around but not RTL DO_LAND_START usage
Copy link
Contributor

@timtuxworth timtuxworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest the values for RTL_AUTOLAND are:

Value Meaning
0 Disable
1 Home - Enable fly HOME or to a Rally point then land
2 Land - Enable go directly to landing sequence
3 Go Around - Disable but allow Arming with DO_LAND_START in the mission for go arounds.

This is because in QGC, you only see the first few letters of each option, as per this screen shot.
Screen Shot 2022-03-22 at 5 53 49 PM

@tridge tridge removed the DevCallEU label Mar 23, 2022
@tridge tridge merged commit 680162c into ArduPilot:master Mar 23, 2022
@tridge tridge added this to pending in Plane 4.2 Mar 24, 2022
@tridge tridge moved this from pending to merged in Plane 4.2 Mar 24, 2022
// @Description: Automatically begin landing sequence after arriving at RTL location. This requires the addition of a DO_LAND_START mission item, which acts as a marker for the start of a landing sequence. The closest landing sequence will be chosen to the current location.
// @Values: 0:Disable,1:Enable - go HOME then land,2:Enable - go directly to landing sequence
// @Description: Automatically begin landing sequence after arriving at RTL location. This requires the addition of a DO_LAND_START mission item, which acts as a marker for the start of a landing sequence. The closest landing sequence will be chosen to the current location. If this is set to 0 and there is a DO_LAND_START mission item then you will get an arming check failure. You can set to a value of 3 to avoid the arming check failure and use the DO_LAND_START for go-around without it changing RTL behaviour. For a value of 1 a rally point will be used instead of HOME if in range (see rally point documentation).
// @Values: 0:Disable,1:Fly HOME then land,2:Go directly to landing sequence, 3:OnlyForGoAround
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// @Values: 0:Disable,1:Fly HOME then land,2:Go directly to landing sequence, 3:OnlyForGoAround

I think this should be renamed it confused me and I made a 4: DisableArmCheck or 4: DisableArmCheck_NoRTL. U

I had little reason for checking the extended descriptions since I didn't want a GoAround. I want it for ship landing scripting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants