Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector3: return w1 not zero vector #20369

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

xianglunkai
Copy link
Contributor

fix liitle bugs when w1=w2

@IamPete1
Copy link
Member

Looks like you will also have to update the test.

EXPECT_VECTOR3F_EQ((Vector3f{0.0f, 0.0f, 0.0f}), intersection_null);

@xianglunkai
Copy link
Contributor Author

Thank you! test have been fixed!

Copy link
Contributor

@rishabsingh3003 rishabsingh3003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that was a mistake I made. Thanks for fixing it!
Did you mean to include th harmonic notch change as well? Not sure if it belongs to this PR

@xianglunkai
Copy link
Contributor Author

@rishabsingh3003 Txs,only merge vector3 pr.

@amilcarlucas
Copy link
Contributor

@xianglunkai we can not select what parts to merge. You need to remove the harmonic notch change yourself

@xianglunkai
Copy link
Contributor Author

@amilcarlucas Txs

@rmackay9 rmackay9 merged commit abb0bf3 into ArduPilot:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants