-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vector3: return w1 not zero vector #20369
vector3: return w1 not zero vector #20369
Conversation
Looks like you will also have to update the test.
|
Thank you! test have been fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that was a mistake I made. Thanks for fixing it!
Did you mean to include th harmonic notch change as well? Not sure if it belongs to this PR
@rishabsingh3003 Txs,only merge vector3 pr. |
@xianglunkai we can not select what parts to merge. You need to remove the harmonic notch change yourself |
ab7d722
to
47292af
Compare
@amilcarlucas Txs |
fix liitle bugs when w1=w2