New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_EFI/AP_PiccoloCAN: Add Currawong ECU support #20399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comment to get past your first CI error:
Add the following under here should fix it
'kg/m/m' : 'kilograms per square meter', # metre is the SI unit name, meter is the american spelling of it |
'kg/m/m/m' : 'kilograms per cubic meter',
We will eventually need to clean up you commit list a bit by squashing the "clean up" commits. ArduPilot doesn't use merge commits. Instead we rebase our working branch on top of the master (development) branch. https://ardupilot.org/dev/docs/git-interactive-rebase.html
I can help you with GIT if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes.
Note: I didn't look over the PiccoloCAN parts yet
d7bb860
to
7d90bea
Compare
7d90bea
to
6c5c454
Compare
Rebased on top of master and to clean up commit history, happy to squash it down more if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits look reasonable enough to me.
Some style things. I didn't go through the generated code.
I'm probably not the person for reviewing the CAN changes. As I'm not as familiar with the their structure enough to ensure thread safety.
This one is outside of my scope to approve. But I'm glad to see it built locally now :)
a3e5093
to
f66cc5e
Compare
ba213a9
to
b600ddc
Compare
@hendjoshsr71 any further requirements for review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice!
b600ddc
to
c23ee79
Compare
@tridge @peterbarker Any updates on having this approved? |
@reilly-callaway needs a rebase as conflicted, then ping me to merge this |
ff0022f
to
da28c6a
Compare
da28c6a
to
d3b13fb
Compare
d3b13fb
to
3a51edd
Compare
@tridge Rebased and all tests passing. Should be good to merge. |
3a51edd
to
48e77c5
Compare
Merged, thanks! |
Example with Currawong ECU connected to CubeOrange over CAN. Shows EFI mavlink status in Mission Planner (matching data in Currawong's internal tool) with throttle set by Ardupilot: