Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Airspeed: correct metadata for params for non-Plane vehicles #20422

Merged
merged 1 commit into from
Apr 4, 2022
Merged

AP_Airspeed: correct metadata for params for non-Plane vehicles #20422

merged 1 commit into from
Apr 4, 2022

Conversation

Hwurzburg
Copy link
Collaborator

No description provided.

hendjoshsr71
hendjoshsr71 requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@hendjoshsr71 hendjoshsr71 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Henry.

Sorry for the conflicting info. I gave you when we talked. I took more time to inspect the code and WIND_WARN and the options will function in terms of GCS output if someone sets USE ==1.

We could force USE to always be 0, but I think the behavior of testing the other functionality of the airspeed code is ok if someone wants to. But not advertise it. As long as USE doesn't effect control & estimation.

Disabling voltage correction will still work.

libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
libraries/AP_Airspeed/AP_Airspeed.cpp Outdated Show resolved Hide resolved
@tridge tridge merged commit fa81f78 into ArduPilot:master Apr 4, 2022
@Hwurzburg Hwurzburg deleted the airspeed_metadata branch April 5, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

@hendjoshsr71 hendjoshsr71 hendjoshsr71 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hwurzburg @tridge @hendjoshsr71 @CraigElder