Fast sampling for ICM45686 #22144
Merged
Fast sampling for ICM45686 #22144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-icm45686-gyro-rate
branch
from
a569e26
to
148320a
Compare
tridge
requested changes
Nov 9, 2022
|
@bugobliterator Andy says the accel scale was wrong? do you have flight test logs? |
|
Here is the log with master. @tridge It doesn't look like there are any scaling issues. Will discuss with @andyp1per further on what's happening on his Cube |
bugobliterator
force-pushed
the
pr-icm45686-gyro-rate
branch
from
af48fee
to
e58a8bd
Compare
andyp1per
force-pushed
the
pr-icm45686-gyro-rate
branch
2 times, most recently
from
ba332a9
to
1f34b1c
Compare
Fix accel scale on ICM45686
andyp1per
force-pushed
the
pr-icm45686-gyro-rate
branch
from
1f34b1c
to
442bd5e
Compare
tridge
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now reflects #22931 but with the additional fix that is required.
I tested on 42688's and on CubeOrangePlus - all working as expected