Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Mount: fix for Siyi A8 #22313

Merged
merged 2 commits into from
Nov 30, 2022
Merged

AP_Mount: fix for Siyi A8 #22313

merged 2 commits into from
Nov 30, 2022

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Nov 29, 2022

This PR includes two fixes for the AP_Mount Siyi driver:

  1. add support for the A8 gimbal which uses a shortened firmware version reply message (discussion)
  2. fixes a bug in the firmware version banner displayed when the autopilot first connects with the gimbal

This has been successfully tested on real hardware (a CubeOrange with a SiyiA8 attached). Below is a screen shot of the corrected version display.
version-display-fix-after

I've marked this for backporting to 4.3 because it is a relatively low risk change and I think it is quite important that we support this gimbal.

@tridge tridge merged commit 204d32c into ArduPilot:master Nov 30, 2022
@rmackay9 rmackay9 deleted the siyia8-fix branch November 30, 2022 11:27
@rmackay9 rmackay9 added this to Pending in Copter 4.3 Dec 8, 2022
@rmackay9 rmackay9 moved this from Pending to 4.3.2-rc1 in Copter 4.3 Dec 8, 2022
@tridge tridge added this to 4.3.2-beta2 in Plane 4.3 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Copter 4.3
4.3.2-rc1
Plane 4.3
4.3.2-beta2
Development

Successfully merging this pull request may close these issues.

None yet

3 participants