Jump Tags: add scripting hooks and examples #23000
Conversation
|
we will wait till 1st one merges |
magicrub
force-pushed
the
pr/jump_tag_scripting
branch
from
b529e12
to
8426998
Compare
First one has merged |
|
Lua changes from the merged PR #22861 is causing LUA doc warnings which is now blocking this PR.. and any other PR that has LUA bindings changes |
No, only the ones that try to have CI run again. PRs that have already passed CI can be merged, breaking master ;-) Not sure what the point of this comment was - there are new requirements, satisfy them? |
libraries/AP_Scripting/docs/docs.lua
Outdated
| -- desc | ||
| ---@return number |
There was a problem hiding this comment.
Kind of sparse documentation, right? Knowing what sort of altitude is returned would be nice to have in the documentation (AMSL would be most outsider's guess, and I'm guess that that guess would be wrong).
Is there facility for more information in these documentation strings?
There was a problem hiding this comment.
Yes, just add more text on the same line. There are some that are more thoroughly documented, would be good to get them all fully documented eventually.
magicrub
force-pushed
the
pr/jump_tag_scripting
branch
2 times, most recently
from
e5909ca
to
e8f5de7
Compare
magicrub
force-pushed
the
pr/jump_tag_scripting
branch
from
e8f5de7
to
b492bfb
Compare
|
@peterbarker @IamPete1 I've added all the comments from the libraries into the script desc for all of Baro and Mission |
| @@ -2091,6 +2091,18 @@ uint16_t AP_Mission::get_index_of_jump_tag(const uint16_t tag) const | |||
| return 0; | |||
| } | |||
|
|
|||
| #if AP_SCRIPTING_ENABLED | |||
| bool AP_Mission::get_last_jump_tag(uint16_t &tag, uint16_t &age) const | |||
There was a problem hiding this comment.
needs a comment for units of age (the name makes it sound like a time, which is isn't)
| ---@return boolean | ||
| function mission:clear() end | ||
|
|
||
| -- desc | ||
| -- set any WP items in any order in a mavlink-ish kinda way. |
There was a problem hiding this comment.
what does this comment mean? "mavlink-ish" ??
This PR extends PR #22421 and adds two scripts: