Tools: add COLCON_IGNORE to modules and libraries #23507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent colcon from searching in modules and libraries for CMakeLists.txt. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
khancyr
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
I would say ok if it solves the issue currently. Those file wont bother other tools so that is fine.
One thing that could be annoying would be that we need to put those file everywhere, but we could deal we that later. I don't have strong knoledge on colcon, but I assume we could have a config file or have a pre-build rules to pass all path to except if we need more that those
|
tridge
approved these changes
Apr 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent colcon from searching in modules and libraries for CMakeLists.txt.
This removes the need to specify or otherwise filter packages when building ROS 2 / DDS cmake projects with colcon.
Related to: