AC_WPNav: wpnav speed param check fixed #23544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #23220
This PR fixes an issue where RTL_SPEED = 400 but if users changed the WPNAV_SPEED parameter the vehicle would immediately change to this new speed.
This has been tested in SITL to confirm that user changes to WPNAV_SPEED will only take effect if the WPNAV_SPEED parameter value was used to initialise the vehicle's speed in the current mode. The results are slightly unintuitive in some situations though so I'm happy to discuss if people think the behaviour is odd.
Below are some screenshots of SITL testing because PRs with pictures are nicer to look at.
![image](https://user-images.githubusercontent.com/1498098/233074074-a4dfb807-28bc-471b-9a2c-f152fcc821fb.png)